Will-Lo commented on code in PR #3667:
URL: https://github.com/apache/gobblin/pull/3667#discussion_r1163465018
##########
gobblin-metrics-libs/gobblin-metrics-base/src/main/avro/GaaSObservabilityEventExperimental.avsc:
##########
@@ -208,12 +208,17 @@
{
"name": "bytesWritten",
"type": "long",
- "doc": "Number of bytes written for the dataset"
+ "doc": "Number of bytes written for the dataset, can be -1 if
unsupported by the writer (e.g. jdbc writer)"
},
{
- "name": "recordsWritten",
+ "name": "entitiesWritten",
"type": "long",
- "doc": "Number of records written for the dataset"
+ "doc": "Number of entities written for the dataset by the
Gobblin writer"
+ },
+ {
+ "name": "datasetCommitSucceeded",
Review Comment:
Going to name it `successfullyCommitted` so lombok doesn't add
`isWasCommitted`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
