phet commented on code in PR #3669:
URL: https://github.com/apache/gobblin/pull/3669#discussion_r1164446591
##########
gradle/scripts/dependencyDefinitions.gradle:
##########
@@ -49,8 +49,9 @@ ext.externalDependency = [
"commonsPool": "org.apache.commons:commons-pool2:2.4.2",
"datanucleusCore": "org.datanucleus:datanucleus-core:3.2.10",
"datanucleusRdbms": "org.datanucleus:datanucleus-rdbms:3.2.9",
+ "errorProne": "com.google.errorprone:error_prone_annotations:2.0.15",
Review Comment:
yes, I see... makes sense there would be no `import`s needed in the case of
one of our direct deps having left out their own dependency so it falls instead
upon us to specify for them. clearly preferable when transitive dependency
resolution automates the solution... but now that we know what's missing, not
too hard for us to add manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]