vikrambohra commented on code in PR #3672:
URL: https://github.com/apache/gobblin/pull/3672#discussion_r1164500993
##########
gobblin-iceberg/src/main/java/org/apache/gobblin/iceberg/writer/IcebergMetadataWriter.java:
##########
@@ -801,12 +813,14 @@ public void flush(String dbName, String tableName) throws
IOException {
Transaction transaction = tableMetadata.transaction.get();
Map<String, String> props = tableMetadata.newProperties.or(
Maps.newHashMap(tableMetadata.lastProperties.or(getIcebergTable(tid).properties())));
- String topic = props.get(TOPIC_NAME_KEY);
+ //Set data offset range
+ setDatasetOffsetRange(tableMetadata, props);
+ String topicName = getTopicName(tid, tableMetadata);
Review Comment:
Is
tableMetadataMap.get(tid).setDatasetName(gmce.getDatasetIdentifier().getNativeName());
required after this change to a new way to get topic name?
##########
gobblin-iceberg/src/main/java/org/apache/gobblin/iceberg/writer/IcebergMetadataWriter.java:
##########
@@ -780,6 +782,16 @@ private StructLike
getIcebergPartitionVal(Collection<HiveSpec> specs, String fil
return partitionVal;
}
+ protected String getTopicName(TableIdentifier tid, TableMetadata
tableMetadata) {
Review Comment:
Lets add Javadoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
