arjun4084346 commented on code in PR #3642:
URL: https://github.com/apache/gobblin/pull/3642#discussion_r1169256081
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/mapreduce/MRJobLauncher.java:
##########
@@ -228,8 +231,17 @@ public MRJobLauncher(Properties jobProps, Configuration
conf, SharedResourcesBro
this.fs.delete(this.mrJobDir, true);
}
this.unsharedJarsDir = new Path(this.mrJobDir, JARS_DIR_NAME);
- this.jarsDir = this.jobProps.containsKey(ConfigurationKeys.MR_JARS_DIR) ?
new Path(
- this.jobProps.getProperty(ConfigurationKeys.MR_JARS_DIR)) :
this.unsharedJarsDir;
+
+ if (this.jobProps.containsKey(ConfigurationKeys.MR_JARS_BASE_DIR)) {
+ Path jarsBaseDir = new
Path(this.jobProps.getProperty(ConfigurationKeys.MR_JARS_BASE_DIR));
+ String monthSuffix = new
SimpleDateFormat("yyyy-MM").format(System.currentTimeMillis());
+ cleanUpOldJarsDirIfRequired(this.fs, jarsBaseDir);
+ this.jarsDir = new Path(jarsBaseDir, monthSuffix);
+ } else {
Review Comment:
That looks better, just wanted to make minimal changes to show in a diff to
the reviewer :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
