[
https://issues.apache.org/jira/browse/GOBBLIN-1816?focusedWorklogId=857746&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-857746
]
ASF GitHub Bot logged work on GOBBLIN-1816:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Apr/23 19:39
Start Date: 18/Apr/23 19:39
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #3676:
URL: https://github.com/apache/gobblin/pull/3676#discussion_r1170491660
##########
gobblin-api/src/main/java/org/apache/gobblin/service/ServiceConfigKeys.java:
##########
@@ -32,7 +32,7 @@ public class ServiceConfigKeys {
public static final String GOBBLIN_SERVICE_TOPOLOGY_CATALOG_ENABLED_KEY =
GOBBLIN_SERVICE_PREFIX + "topologyCatalog.enabled";
public static final String GOBBLIN_SERVICE_FLOW_CATALOG_ENABLED_KEY =
GOBBLIN_SERVICE_PREFIX + "flowCatalog.enabled";
public static final String GOBBLIN_SERVICE_SCHEDULER_ENABLED_KEY =
GOBBLIN_SERVICE_PREFIX + "scheduler.enabled";
-
+ public static final String GOBBLIN_SERVICE_INSTANCE_NAME =
GOBBLIN_SERVICE_PREFIX + "instance.name";
Review Comment:
No, more like for each colo
Issue Time Tracking
-------------------
Worklog Id: (was: 857746)
Time Spent: 40m (was: 0.5h)
> Add flow metadata for GaaSObservabilityEvents
> ---------------------------------------------
>
> Key: GOBBLIN-1816
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1816
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> ObservabilityEvents can be enhanced with metadata to make it easier to query
> specific job properties and differentiate between different instances of GaaS
> that publish to the same Kafka Topic.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
