homatthew opened a new pull request, #3681: URL: https://github.com/apache/gobblin/pull/3681
Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-1819] My Gobblin PR" - https://issues.apache.org/jira/browse/GOBBLIN-1819 ### Description - [X] Here are some details about my PR, including screenshots (if applicable): Logging during helix workflow submission are currently pretty unhelpful. I Here are some examples of what has changed. ``` Before: Waiting for work flow initialization. After: Waiting for workflow initialization. workflowName=job_GobblinHelixJobLauncherTest1_1504201348470, jobName=job_GobblinHelixJobLauncherTest1_1504201348470, timeSubmittedEpoch=1681873657577, timeoutSeconds=300 ``` ``` Before: Work flow job_KafkaHdfsStreamingTrackingOrcMedVol0_1680885392649 initialized After: Workflow job_GobblinHelixJobLauncherTest1_1504201348470 initialized. timeToInitMs=2003 ``` ``` ContainerInfo{container=container_1_0000_00_000000, helixParticipantId='helixInstance1', helixTag='helixTag', startupCommand='$JAVA_HOME/bin/java -Xmx1628M -Duser.timezone=America/Los_Angeles -Dgobblin.yarn.app.container.log.dir=<LOG_DIR> -Dgobblin.yarn.app.container.log.file=GobblinYarnTaskRunner.stdout org.apache.gobblin.yarn.GobblinYarnTaskRunner --app_name testApp2 --app_id appId2 --helix_instance_name helixInstance1 --helix_instance_tags helixTag 1><LOG_DIR>/GobblinYarnTaskRunner.stdout 2><LOG_DIR>/GobblinYarnTaskRunner.stderr'} ``` ### Tests - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: ### Commits - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
