[
https://issues.apache.org/jira/browse/GOBBLIN-1826?focusedWorklogId=859289&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-859289
]
ASF GitHub Bot logged work on GOBBLIN-1826:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Apr/23 03:23
Start Date: 27/Apr/23 03:23
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3688:
URL: https://github.com/apache/gobblin/pull/3688#issuecomment-1524591065
##
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3688?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3688](https://codecov.io/gh/apache/gobblin/pull/3688?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(eadea87) into
[master](https://codecov.io/gh/apache/gobblin/commit/633891080536b39f8c9c127af932d7e8b601b79e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(6338910) will **decrease** coverage by `2.22%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3688 +/- ##
============================================
- Coverage 46.97% 44.76% -2.22%
+ Complexity 10784 2091 -8693
============================================
Files 2138 411 -1727
Lines 84040 17721 -66319
Branches 9340 2159 -7181
============================================
- Hits 39480 7932 -31548
+ Misses 40969 8932 -32037
+ Partials 3591 857 -2734
```
[see 1729 files with indirect coverage
changes](https://codecov.io/gh/apache/gobblin/pull/3688/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Issue Time Tracking
-------------------
Worklog Id: (was: 859289)
Time Spent: 20m (was: 10m)
> Fix bug in Hive registration code where fields could be miscasted in types
> --------------------------------------------------------------------------
>
> Key: GOBBLIN-1826
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1826
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-core
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> After the Guava 20 upgrade, there was a major bug in the Hive registration
> code where fields could be casted as an unexpected type in
> HiveRegistrationUnitÂ
> {code:java}
> protected static <T> Optional<T> populateField(State state, String key,
> TypeToken<T> token) {
> {code}
> The field setter is returning an Optional generic, which allows the code to
> compile but fail during runtime as the types are mismatched, leading to a
> casting exception when reading the type e.g.
> {code:java}
> java.lang.ClassCastException: java.lang.String cannot be cast to
> java.lang.Long at
> org.apache.gobblin.hive.metastore.HiveMetaStoreUtils.getTable(HiveMetaStoreUtils.java:111)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
