[
https://issues.apache.org/jira/browse/GOBBLIN-1827?focusedWorklogId=859537&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-859537
]
ASF GitHub Bot logged work on GOBBLIN-1827:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Apr/23 03:18
Start Date: 28/Apr/23 03:18
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3689:
URL: https://github.com/apache/gobblin/pull/3689#issuecomment-1526927318
##
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3689?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3689](https://codecov.io/gh/apache/gobblin/pull/3689?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(eae0712) into
[master](https://codecov.io/gh/apache/gobblin/commit/e47aef7f8eeba3b6d52901cab299048a467eaf24?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(e47aef7) will **increase** coverage by `4.13%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3689 +/- ##
============================================
+ Coverage 46.99% 51.13% +4.13%
+ Complexity 10788 7216 -3572
============================================
Files 2138 1345 -793
Lines 84040 50666 -33374
Branches 9340 5634 -3706
============================================
- Hits 39497 25906 -13591
+ Misses 40955 22488 -18467
+ Partials 3588 2272 -1316
```
[see 796 files with indirect coverage
changes](https://codecov.io/gh/apache/gobblin/pull/3689/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Issue Time Tracking
-------------------
Worklog Id: (was: 859537)
Remaining Estimate: 0h
Time Spent: 10m
> Avro Flattener should order nested optional fields correctly if they have a
> non-null default value
> --------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1827
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1827
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-core
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> * Consider the following description:
> * Record R1 \{
> * fields : {[
> * {
> * Union : [
> * null,
> * Record R2 {
> * fields : {[
> * {
> * String S1
> *. default: String S3
> * }, \{
> * String S2
> * }
> * ]}
> * }
> * }
> * ]}
> * }
> * will be flattened to:
> * Record R1 \{
> * fields : {[
> * {
> * Union : [ null, String S1]
> *. default: String S3
> * }, \{
> * Union : [ null, String S2]
> * }
> * ]}
> * }
> Due to the addition of the AvroCompatibilityHelper, Avro flattening can run
> into an issue in the above scenario due to the nested non-null default S3
> since the default type needs to be the first type in the field order. So R1
> should have field S1 as Union [String S1, null]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
