rdsr commented on code in PR #3690:
URL: https://github.com/apache/gobblin/pull/3690#discussion_r1182062730
##########
gobblin-core/src/main/java/org/apache/gobblin/writer/PartitionedDataWriter.java:
##########
@@ -326,6 +334,7 @@ public synchronized void close()
serializePartitionInfoToState();
} finally {
closeWritersInCache();
+ this.createWriterPool.shutdown();
Review Comment:
won't this wait for the writer creation thread to be complete before this
function is done? Should we use shutdownnow() with timeout?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
