[
https://issues.apache.org/jira/browse/GOBBLIN-1828?focusedWorklogId=859955&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-859955
]
ASF GitHub Bot logged work on GOBBLIN-1828:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/May/23 04:04
Start Date: 02/May/23 04:04
Worklog Time Spent: 10m
Work Description: rdsr commented on code in PR #3690:
URL: https://github.com/apache/gobblin/pull/3690#discussion_r1182062730
##########
gobblin-core/src/main/java/org/apache/gobblin/writer/PartitionedDataWriter.java:
##########
@@ -326,6 +334,7 @@ public synchronized void close()
serializePartitionInfoToState();
} finally {
closeWritersInCache();
+ this.createWriterPool.shutdown();
Review Comment:
won't this wait for the writer creation thread to be complete before this
function is done? Should we use shutdownnow() with timeout?
Issue Time Tracking
-------------------
Worklog Id: (was: 859955)
Time Spent: 1h (was: 50m)
> Implement Timeout for Creating Writer Functionality
> ---------------------------------------------------
>
> Key: GOBBLIN-1828
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1828
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> When HDFS slowness happens, we can get stuck in creating writer phase and
> never proceed further. So we want to add a timeout guarantee there to make
> sure to fail earlier and retry in this case.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
