[ 
https://issues.apache.org/jira/browse/GOBBLIN-1824?focusedWorklogId=860193&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-860193
 ]

ASF GitHub Bot logged work on GOBBLIN-1824:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/May/23 22:36
            Start Date: 02/May/23 22:36
    Worklog Time Spent: 10m 
      Work Description: Will-Lo commented on code in PR #3686:
URL: https://github.com/apache/gobblin/pull/3686#discussion_r1183109184


##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/ManifestBasedDataset.java:
##########
@@ -117,6 +126,7 @@ public Iterator<FileSet<CopyEntity>> 
getFileSetIterator(FileSystem targetFs, Cop
         CommitStep step = new DeleteFileCommitStep(targetFs, toDelete, 
this.properties, Optional.<Path>absent());
         copyEntities.add(new PrePublishStep(datasetURN(), Maps.newHashMap(), 
step, 1));
       }
+      log.info(String.format("Workunits calculation took %s milliseconds to 
process %s files", System.currentTimeMillis() - startTime, numFiles));

Review Comment:
   Oh I see, in regular distcp it takes a few milliseconds on avg which is why 
the granularity helps but manifest is different





Issue Time Tracking
-------------------

    Worklog Id:     (was: 860193)
    Time Spent: 1h 50m  (was: 1h 40m)

> Improving the Efficiency of Work Planning in Manifest-Based DistCp Jobs
> -----------------------------------------------------------------------
>
>                 Key: GOBBLIN-1824
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1824
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Zihan Li
>            Priority: Major
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Optimizing Permission Calculation and Introducing Multithreading in 
> Manifest-Based DistCp Work Planning



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to