Will-Lo commented on code in PR #3691:
URL: https://github.com/apache/gobblin/pull/3691#discussion_r1183161122
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaAvroJobStatusMonitor.java:
##########
@@ -127,13 +127,14 @@ public org.apache.gobblin.configuration.State
parseJobStatus(GobblinTrackingEven
case TimingEvent.FlowTimings.FLOW_COMPILED:
properties.put(JobStatusRetriever.EVENT_NAME_FIELD,
ExecutionStatus.COMPILED.name());
break;
- case TimingEvent.LauncherTimings.WORK_UNITS_PREPARATION:
+ case TimingEvent.LauncherTimings.WORK_UNITS_CREATION:
properties.put(TimingEvent.WORKUNIT_PLAN_START_TIME,
properties.getProperty(TimingEvent.METADATA_START_TIME));
properties.put(TimingEvent.WORKUNIT_PLAN_END_TIME,
properties.getProperty(TimingEvent.METADATA_END_TIME));
break;
case TimingEvent.LauncherTimings.JOB_START:
case TimingEvent.FlowTimings.FLOW_RUNNING:
case TimingEvent.LauncherTimings.JOB_SUMMARY:
+ case TimingEvent.LauncherTimings.WORK_UNITS_PREPARATION:
Review Comment:
I guess we don't in particular, but it helps store all the specific event
metadata in the state store. Since if the event is being tracked, then it would
add all the event metadata as part of the properties. Otherwise the switch
statement will return null so the event gets completely ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
