[
https://issues.apache.org/jira/browse/GOBBLIN-1823?focusedWorklogId=860842&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-860842
]
ASF GitHub Bot logged work on GOBBLIN-1823:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/May/23 21:40
Start Date: 05/May/23 21:40
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3692:
URL: https://github.com/apache/gobblin/pull/3692#issuecomment-1536809556
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3692?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3692](https://app.codecov.io/gh/apache/gobblin/pull/3692?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(748e55f) into
[master](https://app.codecov.io/gh/apache/gobblin/commit/7bbf6761c63055eb9ecc9f2756d4b3d68b7a1b08?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(7bbf676) will **decrease** coverage by `2.25%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3692 +/- ##
============================================
- Coverage 46.98% 44.74% -2.25%
+ Complexity 10792 2092 -8700
============================================
Files 2138 411 -1727
Lines 84065 17723 -66342
Branches 9342 2160 -7182
============================================
- Hits 39501 7930 -31571
+ Misses 40973 8935 -32038
+ Partials 3591 858 -2733
```
[see 1727 files with indirect coverage
changes](https://app.codecov.io/gh/apache/gobblin/pull/3692/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Issue Time Tracking
-------------------
Worklog Id: (was: 860842)
Time Spent: 20m (was: 10m)
> Improving Container Calculation and Allocation Methodology
> ----------------------------------------------------------
>
> Key: GOBBLIN-1823
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1823
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When Yarn allocates "ghost containers" without calling the
> onContainerAllocated() method and when the container is eventually released,
> onContainersCompleted() is called, container numbers mismatches can occur.
> In the onContainerAllocated() method, we add the container to the
> containerMap using the container ID as the key, and increase the count for
> the specific tag.
> In the onContainersCompleted() method, we remove the container from the
> containerMap and decrease the count. However, in some cases, we find that the
> containerMap does not contain the ID, and we ignore this while still
> decreasing the number of the allocated tag. We do this because sometimes
> onContainersCompleted() is called before onContainerAllocated() for the same
> container.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
