[
https://issues.apache.org/jira/browse/GOBBLIN-1831?focusedWorklogId=861247&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861247
]
ASF GitHub Bot logged work on GOBBLIN-1831:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/May/23 19:30
Start Date: 09/May/23 19:30
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3694:
URL: https://github.com/apache/gobblin/pull/3694#issuecomment-1540774373
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3694?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3694](https://app.codecov.io/gh/apache/gobblin/pull/3694?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(6597a5c) into
[master](https://app.codecov.io/gh/apache/gobblin/commit/e47aef7f8eeba3b6d52901cab299048a467eaf24?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(e47aef7) will **decrease** coverage by `2.22%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #3694 +/- ##
============================================
- Coverage 46.99% 44.78% -2.22%
+ Complexity 10788 2094 -8694
============================================
Files 2138 411 -1727
Lines 84040 17725 -66315
Branches 9340 2160 -7180
============================================
- Hits 39497 7938 -31559
+ Misses 40955 8929 -32026
+ Partials 3588 858 -2730
```
| [Impacted
Files](https://app.codecov.io/gh/apache/gobblin/pull/3694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...a/org/apache/gobblin/cluster/HelixJobsMapping.java](https://app.codecov.io/gh/apache/gobblin/pull/3694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhKb2JzTWFwcGluZy5qYXZh)
| `80.95% <100.00%> (+0.62%)` | :arrow_up: |
... and [1731 files with indirect coverage
changes](https://app.codecov.io/gh/apache/gobblin/pull/3694/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Issue Time Tracking
-------------------
Worklog Id: (was: 861247)
Time Spent: 20m (was: 10m)
> Use Flow Execution ID in Gobblin cluster cancellation semantics and jobname
> IDs if possible
> -------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1831
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1831
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: William Lo
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When executing jobs from GaaS to Gobblin cluster, there can be a mismatch of
> flowexecution ids to jobs running on Gobblin cluster.
> To address this, we tried adding the FlowExecutionId to the jobSpec, but that
> meant that jobs could run concurrently on Gobblin cluster when they should
> have been deduped.
> So instead, during cancellation, we want to check if the incoming spec has a
> flow execution ID. If so, then it will cancel the existing job only if the
> flow execution IDs match. Otherwise, it will know that the current job does
> not match the incoming request and should not be deleted.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
