ZihanLi58 opened a new pull request, #3699: URL: https://github.com/apache/gobblin/pull/3699
Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR" - https://issues.apache.org/jira/browse/GOBBLIN-1836 ### Description - [ ] Here are some details about my PR, including screenshots (if applicable): In our system, when a helix disconnection occurs, we take the necessary step to cancel the ongoing job. Furthermore, when we opt for a graceful exit, we ensure that no exception is thew and we mark the task as complete. However, it is important to note that due to this graceful exit, the task cannot be retried accurately. So we need to introduce a cancel flag to make sure we return the correct task status Also, a small fix to add schema.literal when creating a new iceberg table ### Tests - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: Added new unit test for cancellation logic ### Commits - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
