phet commented on code in PR #3700:
URL: https://github.com/apache/gobblin/pull/3700#discussion_r1207471784
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/dag_action_store/MysqlDagActionStore.java:
##########
@@ -137,12 +139,12 @@ public boolean deleteDagAction(String flowGroup, String
flowName, String flowExe
connection.commit();
return result != 0;
} catch (SQLException e) {
- throw new IOException(String.format("Failure to delete action for table
%s of flow with flow group:%s, flow name:%s and flow execution id:%s",
- tableName, flowGroup, flowName, flowExecutionId), e);
+ throw new IOException(String.format("Failure to delete action for table
%s of flow with flow group:%s, flow name:%s, flow execution id:%s and
dagAction: %s",
+ tableName, flowGroup, flowName, flowExecutionId, dagActionValue), e);
Review Comment:
tip: if you used `DagAction` as a POJO, you could use its `.toString()` to
the same effect--w/o duplication across each similar log message. e.g.:
```
IOE(String.format("...of flow with %s", tableName, dagAction), e);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
