[
https://issues.apache.org/jira/browse/GOBBLIN-1837?focusedWorklogId=862827&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-862827
]
ASF GitHub Bot logged work on GOBBLIN-1837:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 30/May/23 18:56
Start Date: 30/May/23 18:56
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #3700:
URL: https://github.com/apache/gobblin/pull/3700#discussion_r1210699415
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/SchedulerLeaseDeterminationStore.java:
##########
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.runtime.api;
+
+import java.io.IOException;
+import java.sql.Timestamp;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+/**
+ * Interface defines the two basic actions required for lease determination
for each FlowActionType event for a flow.
+ * It is used by the {@link SchedulerLeaseAlgoHandler} to allow multiple
scheduler's on different hosts to determine
+ * which scheduler is tasked with ensuring the FlowAction is taken for the
trigger.
+ */
+public interface SchedulerLeaseDeterminationStore {
+ static final Logger LOG =
LoggerFactory.getLogger(SchedulerLeaseDeterminationStore.class);
+
+ // Enum is used to reason about the three possible scenarios that can result
from an attempt to obtain a lease for a
+ // particular trigger event of a flow
+ enum LeaseAttemptStatus {
+ LEASE_OBTAINED,
+ PREVIOUS_LEASE_EXPIRED,
+ PREVIOUS_LEASE_VALID
Review Comment:
those are the similar ideas, although I'm not sure what the second and third
states exactly entail in the states you described above. For the second state
it tells us the lease is given to another but not sure if another host is in
the process of pursuing or completed lease. What is the third case? Is that if
another host completed pursuing the lease?
I was thinking having the states represent the next course of action.
```
Case 1: lease is acquired completely by itself or another host (do nothing
after)
Case 2: lease attempted by another expired (can try to get lease now)
Case 3: previous lease attempt still ongoing (set a reminder to check back
on lease)
```
Issue Time Tracking
-------------------
Worklog Id: (was: 862827)
Time Spent: 50m (was: 40m)
> Implement multi-active, non blocking for leader host
> ----------------------------------------------------
>
> Key: GOBBLIN-1837
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1837
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> This task will include the implementation of non-blocking, multi-active
> scheduler for each host. It will NOT include metric emission or unit tests
> for validation. That will be done in a separate follow-up ticket. The work in
> this ticket includes
> * define a table to do scheduler lease determination for each flow's trigger
> event and related methods to execute actions on this table
> * update DagActionStore schema and DagActionStoreMonitor to act upon new
> "LAUNCH" type events in addition to KILL/RESUME
> * update scheduler/orchestrator logic to apply the non-blocking algorithm
> when "multi-active scheduler mode" is enabled, otherwise submit events
> directly to the DagManager after receiving a scheduler trigger
> * implement the non-blocking algorithm, particularly handling reminder
> events if another host is in the process of securing the lease for a
> particular flow trigger
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
