[
https://issues.apache.org/jira/browse/GOBBLIN-1838?focusedWorklogId=862840&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-862840
]
ASF GitHub Bot logged work on GOBBLIN-1838:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 30/May/23 21:21
Start Date: 30/May/23 21:21
Worklog Time Spent: 10m
Work Description: wsarecv opened a new pull request, #3701:
URL: https://github.com/apache/gobblin/pull/3701
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title.
- https://issues.apache.org/jira/browse/GOBBLIN-1838
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
- Currently the completion watermark is determined according to the
completeness percentage: `max of srcCount/refCount, for each refTier`. This
change introduces a new "total count based completion watermark", which is
determined by a new completeness percentage: `srcCount / sum of all refCount,
for each refTier`.
- The new total count based watermark will be used to check the
completeness of data which is aggregated from multiple tiers.
### Tests
- [ ] My PR adds the following unit tests:
- `KafkaAuditCountVerifierTest`
- `IcebergMetadataWriterTest`
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 862840)
Remaining Estimate: 0h
Time Spent: 10m
> Introduce total count based completion watermark
> ------------------------------------------------
>
> Key: GOBBLIN-1838
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1838
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Andy Jiang
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently the completion watermark is determined according to the
> completeness percentage: "max of srcCount/refCount, for each refTier".
> This change introduces a new "total count based completion watermark", which
> is determined by a new completeness percentage: "srcCount / sum of all
> refCount, for each refTier".
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
