phet commented on code in PR #3700:
URL: https://github.com/apache/gobblin/pull/3700#discussion_r1211093441
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/DagActionStore.java:
##########
@@ -27,7 +27,9 @@
public interface DagActionStore {
enum DagActionValue {
KILL,
- RESUME
+ RESUME,
+ // TODO: potentially combine this enum with {@link
SchedulerLeaseDeterminationStore.FlowActionType}
+ LAUNCH
}
@Getter
Review Comment:
I imagined simply:
```
@Data
class DagAction {
final String flowGroup;
final String flowName;
final String flowExecutionId;
final DagActionValue dagActionValue;
}
```
also, not a bad idea to reuse enums, whenever perfect overlap
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
