[
https://issues.apache.org/jira/browse/GOBBLIN-1837?focusedWorklogId=863172&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863172
]
ASF GitHub Bot logged work on GOBBLIN-1837:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jun/23 02:57
Start Date: 01/Jun/23 02:57
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3700:
URL: https://github.com/apache/gobblin/pull/3700#discussion_r1212509675
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/DagActionStore.java:
##########
@@ -45,6 +44,11 @@ public DagAction(String flowGroup, String flowName, String
flowExecutionId, DagA
this.flowExecutionId = flowExecutionId;
this.dagActionValue = dagActionValue;
}
Review Comment:
won't `@Data` synthesize a ctor for us? also, how does the synthesized
`toString()` compare to the hand-coded one below?
##########
gobblin-metrics-libs/gobblin-metrics-base/src/main/avro/DagActionStoreChangeEvent.avsc:
##########
@@ -25,7 +25,13 @@
"compliance" : "NONE"
}, {
"name" : "dagAction",
- "type" : "string",
+ "type": "enum",
+ "name": "dagActionValue",
+ "symbols": [
+ "KILL",
+ "RESUME",
+ "LAUNCH"
+ ],
Review Comment:
usually each enum gets documentation
Issue Time Tracking
-------------------
Worklog Id: (was: 863172)
Time Spent: 6.5h (was: 6h 20m)
> Implement multi-active, non blocking for leader host
> ----------------------------------------------------
>
> Key: GOBBLIN-1837
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1837
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 6.5h
> Remaining Estimate: 0h
>
> This task will include the implementation of non-blocking, multi-active
> scheduler for each host. It will NOT include metric emission or unit tests
> for validation. That will be done in a separate follow-up ticket. The work in
> this ticket includes
> * define a table to do scheduler lease determination for each flow's trigger
> event and related methods to execute actions on this table
> * update DagActionStore schema and DagActionStoreMonitor to act upon new
> "LAUNCH" type events in addition to KILL/RESUME
> * update scheduler/orchestrator logic to apply the non-blocking algorithm
> when "multi-active scheduler mode" is enabled, otherwise submit events
> directly to the DagManager after receiving a scheduler trigger
> * implement the non-blocking algorithm, particularly handling reminder
> events if another host is in the process of securing the lease for a
> particular flow trigger
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
