umustafi commented on code in PR #3700: URL: https://github.com/apache/gobblin/pull/3700#discussion_r1223557068
########## gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/LeasedToAnotherStatus.java: ########## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.gobblin.runtime.api; + +import lombok.Getter; + +/* +The event in question has been leased to another. This object contains `reminderEventTimestamp` which is the event +timestamp the lease is associated with as well as `minimumReminderWaitMillis` the minimum amount of time to wait +before returning to check if the lease has completed or expired. + */ +public class LeasedToAnotherStatus extends LeaseAttemptStatus { + @Getter + private final long reminderEventTimeMillis; Review Comment: I wanted to distinguish that the event with a lease may not be the same event that the host tried to acquire a lease for ie: a previous trigger for the same flow action so it's the eventTimestamp associated with the lease and `minimumLingerDurationMillis`. Edit: Clarifying the aforementioned with in the comment/javadoc for the class and update the naming. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
