phet commented on code in PR #3700:
URL: https://github.com/apache/gobblin/pull/3700#discussion_r1227790521


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/restli/GobblinServiceFlowExecutionResourceHandlerWithWarmStandby.java:
##########
@@ -55,31 +55,27 @@ public void 
resume(ComplexResourceKey<org.apache.gobblin.service.FlowStatusId, E
     try {
       // If an existing resume request is still pending then do not accept 
this request
       if (this.dagActionStore.exists(flowGroup, flowName, 
flowExecutionId.toString(), DagActionStore.FlowActionType.RESUME)) {
-        this.handleException(flowGroup, flowName, flowExecutionId.toString(), 
DagActionStore.FlowActionType.RESUME,
-            new RuntimeException("There is already a pending RESUME action for 
this flow. Please wait to resubmit and wait for"
-                + " action to be completed."));
+        this.handleException("There is already a pending RESUME action for 
this flow. Please wait to resubmit and wait "

Review Comment:
   nit: `handleError` / `prepareError` / `formulateError` (?)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to