[
https://issues.apache.org/jira/browse/GOBBLIN-1842?focusedWorklogId=865335&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-865335
]
ASF GitHub Bot logged work on GOBBLIN-1842:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jun/23 18:21
Start Date: 13/Jun/23 18:21
Worklog Time Spent: 10m
Work Description: jack-moseley opened a new pull request, #3703:
URL: https://github.com/apache/gobblin/pull/3703
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1842
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
Add timers for:
- hivespec computation
- write for each metadata writer
- flush for each metadata writer
These timers are set up with a 1 hour sliding window, so the statistics will
be for the last hour of execution. The timers are registered with metric
context so they will send metrics through gobblin's metric framework. Also,
added logging during every flush interval (every 1 min) which logs the current
mean/99th percentile of every timer, so it is easier to see where time is being
spent.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Ran test pipeline. Example timer logs:
```
2023-06-13 11:16:58 PDT INFO [StreamModelTaskRunner]
org.apache.gobblin.iceberg.writer.GobblinMCEWriter - begin flushing 0 records
2023-06-13 11:16:58 PDT INFO [StreamModelTaskRunner]
org.apache.gobblin.iceberg.writer.GobblinMCEWriter - Timer
org.apache.gobblin.iceberg.writer.IcebergMetadataWriter.write 1 hour mean
duration: 10 ms
2023-06-13 11:16:58 PDT INFO [StreamModelTaskRunner]
org.apache.gobblin.iceberg.writer.GobblinMCEWriter - Timer
org.apache.gobblin.iceberg.writer.IcebergMetadataWriter.write 1 hour 99th
percentile duration: 104 ms
2023-06-13 11:16:58 PDT INFO [StreamModelTaskRunner]
org.apache.gobblin.iceberg.writer.GobblinMCEWriter - Timer
org.apache.gobblin.hive.writer.HiveMetadataWriter.write 1 hour mean duration:
14 ms
2023-06-13 11:16:58 PDT INFO [StreamModelTaskRunner]
org.apache.gobblin.iceberg.writer.GobblinMCEWriter - Timer
org.apache.gobblin.hive.writer.HiveMetadataWriter.write 1 hour 99th percentile
duration: 213 ms
2023-06-13 11:16:58 PDT INFO [StreamModelTaskRunner]
org.apache.gobblin.iceberg.writer.GobblinMCEWriter - Timer
org.apache.gobblin.iceberg.writer.IcebergMetadataWriter.flush 1 hour mean
duration: 3756 ms
2023-06-13 11:16:58 PDT INFO [StreamModelTaskRunner]
org.apache.gobblin.iceberg.writer.GobblinMCEWriter - Timer
org.apache.gobblin.iceberg.writer.IcebergMetadataWriter.flush 1 hour 99th
percentile duration: 69138 ms
2023-06-13 11:16:58 PDT INFO [StreamModelTaskRunner]
org.apache.gobblin.iceberg.writer.GobblinMCEWriter - Timer
org.apache.gobblin.hive.writer.HiveMetadataWriter.flush 1 hour mean duration: 0
ms
2023-06-13 11:16:58 PDT INFO [StreamModelTaskRunner]
org.apache.gobblin.iceberg.writer.GobblinMCEWriter - Timer
org.apache.gobblin.hive.writer.HiveMetadataWriter.flush 1 hour 99th percentile
duration: 1 ms
2023-06-13 11:16:58 PDT INFO [StreamModelTaskRunner]
org.apache.gobblin.iceberg.writer.GobblinMCEWriter - Timer
hiveSpec.computation 1 hour mean duration: 10 ms
2023-06-13 11:16:58 PDT INFO [StreamModelTaskRunner]
org.apache.gobblin.iceberg.writer.GobblinMCEWriter - Timer
hiveSpec.computation 1 hour 99th percentile duration: 19 ms
```
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 865335)
Remaining Estimate: 0h
Time Spent: 10m
> Add timers to GobblinMCEWriter
> ------------------------------
>
> Key: GOBBLIN-1842
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1842
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
