[
https://issues.apache.org/jira/browse/GOBBLIN-1840?focusedWorklogId=865849&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-865849
]
ASF GitHub Bot logged work on GOBBLIN-1840:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jun/23 18:26
Start Date: 15/Jun/23 18:26
Worklog Time Spent: 10m
Work Description: Peiyingy commented on code in PR #3704:
URL: https://github.com/apache/gobblin/pull/3704#discussion_r1231395859
##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixJobScheduler.java:
##########
@@ -333,6 +345,20 @@ public void
handleNewJobConfigArrival(NewJobConfigArrivalEvent newJobArrival) {
@Subscribe
public void handleUpdateJobConfigArrival(UpdateJobConfigArrivalEvent
updateJobArrival) {
LOGGER.info("Received update for job configuration of job " +
updateJobArrival.getJobName());
+ String jobName = updateJobArrival.getJobName();
+ boolean throttleEnabled =
PropertiesUtils.getPropAsBoolean(updateJobArrival.getJobConfig(),
Review Comment:
In the function of getPropAsBoolean, that is:
```
public static boolean getPropAsBoolean( @NotNull Properties properties,
String key,
String defaultValue )
```
so it will call
`String.valueOf(GobblinClusterConfigurationKeys.DEFAULT_HELIX_JOB_SCHEDULING_THROTTLE_ENABLED_KEY)
`as the default value if
`GobblinClusterConfigurationKeys.HELIX_JOB_SCHEDULING_THROTTLE_ENABLED_KEY` is
not assigned
Issue Time Tracking
-------------------
Worklog Id: (was: 865849)
Time Spent: 1h 50m (was: 1h 40m)
> Helix Job scheduler should not try to replace running workflow if within
> configured time
> ----------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1840
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1840
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Matthew Ho
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
