ZihanLi58 commented on code in PR #3709:
URL: https://github.com/apache/gobblin/pull/3709#discussion_r1239001875
##########
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnAutoScalingManager.java:
##########
@@ -220,16 +220,18 @@ void runInternal() {
YarnContainerRequestBundle yarnContainerRequestBundle = new
YarnContainerRequestBundle();
for (Map.Entry<String, WorkflowConfig> workFlowEntry :
taskDriver.getWorkflows().entrySet()) {
WorkflowContext workflowContext =
taskDriver.getWorkflowContext(workFlowEntry.getKey());
+ WorkflowConfig workflowConfig = workFlowEntry.getValue();
- // Only allocate for active workflows
- if (workflowContext == null ||
!workflowContext.getWorkflowState().equals(TaskState.IN_PROGRESS)) {
+ // Only allocate for active workflows and those not marked for delete
Review Comment:
Can you add a comment here to explain that we won't release the container
immediately as we allow containers to be idle for a specific time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
