ZihanLi58 commented on code in PR #3711:
URL: https://github.com/apache/gobblin/pull/3711#discussion_r1244392764
##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixJobLauncher.java:
##########
@@ -462,10 +466,14 @@ public void launchJob(@Nullable JobListener jobListener)
throws JobException {
}
// TODO: Better error handling. The current impl swallows exceptions for
jobs that were started by this method call.
- // One potential way to improve the error handling is to make this error
swallowing conifgurable
+ // One potential way to improve the error handling is to make this error
swallowing configurable
} catch (Throwable t) {
errorInJobLaunching = t;
} finally {
+ if (isCancelWorkflowOnExitEnabled) {
+ cancelJob(jobListener);
Review Comment:
If the workflow is complete correctly without exception throw out, doesn't
that mean helix already marks the workflow as complete as it's in a clean
state? what's the point to call cancel in that case? I believe in ingestion
cases, We should never exit with complete, if we don't hit an exception, that
means we already mark the workflow as deleted on the helix side and exit
gracefully. Removing work unit states make sense as no matter a workflow is
complete or failed or canceled, we should do the housekeeping.
So I still recommend doing that in the exception block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
