homatthew commented on code in PR #3708:
URL: https://github.com/apache/gobblin/pull/3708#discussion_r1248173524
##########
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java:
##########
@@ -540,26 +537,6 @@ void connectHelixManager() {
}
}
- /**
- * A method to disable pre-existing live instances in a Helix cluster. This
can happen when a previous Yarn application
- * leaves behind orphaned Yarn worker processes. Since Helix does not
provide an API to drop a live instance, we use
- * the disable instance API to fence off these orphaned instances and
prevent them from becoming participants in the
- * new cluster.
- *
- * NOTE: this is a workaround for an existing YARN bug. Once YARN has a fix
to guarantee container kills on application
- * completion, this method should be removed.
- */
Review Comment:
Can you add this comment back to the new impl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
