[
https://issues.apache.org/jira/browse/GOBBLIN-1841?focusedWorklogId=868769&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-868769
]
ASF GitHub Bot logged work on GOBBLIN-1841:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jun/23 18:38
Start Date: 30/Jun/23 18:38
Worklog Time Spent: 10m
Work Description: homatthew commented on code in PR #3708:
URL: https://github.com/apache/gobblin/pull/3708#discussion_r1248173524
##########
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java:
##########
@@ -540,26 +537,6 @@ void connectHelixManager() {
}
}
- /**
- * A method to disable pre-existing live instances in a Helix cluster. This
can happen when a previous Yarn application
- * leaves behind orphaned Yarn worker processes. Since Helix does not
provide an API to drop a live instance, we use
- * the disable instance API to fence off these orphaned instances and
prevent them from becoming participants in the
- * new cluster.
- *
- * NOTE: this is a workaround for an existing YARN bug. Once YARN has a fix
to guarantee container kills on application
- * completion, this method should be removed.
- */
Review Comment:
Can you add this comment back to the new impl
Issue Time Tracking
-------------------
Worklog Id: (was: 868769)
Time Spent: 1h 40m (was: 1.5h)
> Move disabling of current live instances to the GobblinClusterManager startup
> -----------------------------------------------------------------------------
>
> Key: GOBBLIN-1841
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1841
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Matthew Ho
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
