[
https://issues.apache.org/jira/browse/GOBBLIN-1848?focusedWorklogId=868792&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-868792
]
ASF GitHub Bot logged work on GOBBLIN-1848:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jun/23 22:50
Start Date: 30/Jun/23 22:50
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3712:
URL: https://github.com/apache/gobblin/pull/3712#issuecomment-1615256745
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3712?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
> Merging
[#3712](https://app.codecov.io/gh/apache/gobblin/pull/3712?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(b144b94) into
[master](https://app.codecov.io/gh/apache/gobblin/commit/5af6bca57df909e44b995e5b2d667c70e0399877?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(5af6bca) will **decrease** coverage by `1.81%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3712 +/- ##
============================================
- Coverage 46.82% 45.02% -1.81%
+ Complexity 10804 2121 -8683
============================================
Files 2141 412 -1729
Lines 84429 17817 -66612
Branches 9383 2170 -7213
============================================
- Hits 39537 8022 -31515
+ Misses 41294 8936 -32358
+ Partials 3598 859 -2739
```
[see 1742 files with indirect coverage
changes](https://app.codecov.io/gh/apache/gobblin/pull/3712/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Issue Time Tracking
-------------------
Worklog Id: (was: 868792)
Remaining Estimate: 0h
Time Spent: 10m
> Allow extensible DagManager Metrics through tags
> ------------------------------------------------
>
> Key: GOBBLIN-1848
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1848
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> DagManager metrics due to being sent as a gauge in some backend system needs
> differentiation despite using the same ContextAwareMeter class.
> This PR is to add tags (which are extensible) for metric emitting classes to
> check these tags to process before sending the metrics to their corresponding
> backend system
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
