[ 
https://issues.apache.org/jira/browse/GOBBLIN-1853?focusedWorklogId=871642&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-871642
 ]

ASF GitHub Bot logged work on GOBBLIN-1853:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/Jul/23 21:14
            Start Date: 18/Jul/23 21:14
    Worklog Time Spent: 10m 
      Work Description: homatthew commented on code in PR #3716:
URL: https://github.com/apache/gobblin/pull/3716#discussion_r1267312123


##########
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/writer/HiveMetadataWriter.java:
##########
@@ -38,20 +28,37 @@
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.TimeoutException;
 import java.util.stream.Collectors;
-import javax.annotation.Nullable;
 
+import org.apache.avro.Schema;
+import org.apache.avro.generic.GenericRecord;
+import org.apache.avro.specific.SpecificData;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.hadoop.hive.metastore.api.AlreadyExistsException;
+import org.apache.hadoop.hive.serde2.avro.AvroSerdeUtils;
+
+import com.codahale.metrics.Timer;
+import com.google.common.annotations.VisibleForTesting;
+import com.google.common.base.Joiner;
+import com.google.common.base.Optional;
+import com.google.common.base.Throwables;
+import com.google.common.cache.Cache;
+import com.google.common.cache.CacheBuilder;
+import com.google.common.collect.Lists;
+import com.google.common.io.Closer;
+import com.google.common.util.concurrent.ListenableFuture;
+
+import javax.annotation.Nullable;

Review Comment:
   original import ordering did not comply with Apache Gobblin OSS style guide





Issue Time Tracking
-------------------

    Worklog Id:     (was: 871642)
    Time Spent: 20m  (was: 10m)

> Bug: Metadata writers for Iceberg and Hive make unnecessary Hive calls for 
> schema related updates
> -------------------------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-1853
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1853
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Matthew Ho
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to