meethngala commented on code in PR #3717:
URL: https://github.com/apache/gobblin/pull/3717#discussion_r1268777193
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/FlowTriggerHandler.java:
##########
@@ -107,10 +110,12 @@ public void handleTriggerEvent(Properties jobProps,
DagActionStore.DagAction flo
eventTimeMillis);
return;
} else if (leaseAttemptStatus instanceof
MultiActiveLeaseArbiter.LeasedToAnotherStatus) {
+
this.metricContext.contextAwareCounter(ServiceMetricNames.FLOW_TRIGGER_HANDLER_LEASED_TO_ANOTHER_COUNT);
Review Comment:
I wanted to but then realized that we do spit out some logs as part of this
method `scheduleReminderForEvent` and didn't want to make it noisy for emitting
similar logs. However, I have added a debug level log when we no longer attempt
for a lease... since I found that to be missing :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
