[
https://issues.apache.org/jira/browse/GOBBLIN-1861?focusedWorklogId=872941&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-872941
]
ASF GitHub Bot logged work on GOBBLIN-1861:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jul/23 23:00
Start Date: 25/Jul/23 23:00
Worklog Time Spent: 10m
Work Description: jack-moseley opened a new pull request, #3724:
URL: https://github.com/apache/gobblin/pull/3724
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1861
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
The total completion watermark whitelist was not respected when a
change_property GMCE was sent. These should be treated the same as add_files
GMCEs.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Tested with a whitelisted and non-whitelisted topic in test pipeline.
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 872941)
Remaining Estimate: 0h
Time Spent: 10m
> Fix bug with total count watermark whitelist
> --------------------------------------------
>
> Key: GOBBLIN-1861
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1861
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
