[
https://issues.apache.org/jira/browse/GOBBLIN-1869?focusedWorklogId=874735&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-874735
]
ASF GitHub Bot logged work on GOBBLIN-1869:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Aug/23 20:34
Start Date: 04/Aug/23 20:34
Worklog Time Spent: 10m
Work Description: Will-Lo opened a new pull request, #3732:
URL: https://github.com/apache/gobblin/pull/3732
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
Currently the metrics for streaming mainly relate to the Kafka consumption
side. We want to also capture metrics through events from the ORCWriter to
capture the memory usage and internal performance of the writer.
This PR captures the following information:
1. Schema name
2. Bytes written
3. Records written
4. Rowbatch size (buffer size)
5. Resize count
Logs of the fields looks like the below:
```
2023-08-03 18:23:46 PDT INFO [StreamModelTaskRunner]
org.apache.gobblin.writer.InstrumentedGobblinOrcWriter - Emitting ORC event
metrics
2023-08-03 18:23:46 PDT INFO [StreamModelTaskRunner]
org.apache.gobblin.writer.InstrumentedGobblinOrcWriter - Metrics schema name:
FeatureTrackingEvent
2023-08-03 18:23:46 PDT INFO [StreamModelTaskRunner]
org.apache.gobblin.writer.InstrumentedGobblinOrcWriter - Rowbatch size: 1
2023-08-03 18:23:46 PDT INFO [StreamModelTaskRunner]
org.apache.gobblin.writer.InstrumentedGobblinOrcWriter - Resize count: 54
2023-08-03 18:23:46 PDT INFO [StreamModelTaskRunner]
org.apache.gobblin.writer.InstrumentedGobblinOrcWriter - Bytes written:
299372195
2023-08-03 18:23:46 PDT INFO [StreamModelTaskRunner]
org.apache.gobblin.writer.InstrumentedGobblinOrcWriter - Records written: 934
```
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
6. Subject is limited to 50 characters
7. Subject does not end with a period
8. Subject uses the imperative mood ("add", not "adding")
9. Body wraps at 72 characters
10. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 874735)
Remaining Estimate: 0h
Time Spent: 10m
> ORCWriter should emit events to capture metrics on write side
> -------------------------------------------------------------
>
> Key: GOBBLIN-1869
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1869
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-core
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently the metrics for streaming mainly relate to the Kafka consumption
> side. We want to also capture metrics through events from the ORCWriter to
> capture the memory usage and internal performance of the writer.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
