[
https://issues.apache.org/jira/browse/GOBBLIN-1868?focusedWorklogId=874765&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-874765
]
ASF GitHub Bot logged work on GOBBLIN-1868:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Aug/23 00:02
Start Date: 05/Aug/23 00:02
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3731:
URL: https://github.com/apache/gobblin/pull/3731#issuecomment-1666290933
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3731?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
> Merging
[#3731](https://app.codecov.io/gh/apache/gobblin/pull/3731?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(41de9f6) into
[master](https://app.codecov.io/gh/apache/gobblin/commit/208742617cce8d6927145ce770028176d1b02bee?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(2087426) will **decrease** coverage by `1.76%`.
> Report is 1 commits behind head on master.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3731 +/- ##
============================================
- Coverage 47.08% 45.33% -1.76%
+ Complexity 10859 2137 -8722
============================================
Files 2144 413 -1731
Lines 84748 17956 -66792
Branches 9410 2184 -7226
============================================
- Hits 39907 8140 -31767
+ Misses 41221 8949 -32272
+ Partials 3620 867 -2753
```
[see 1735 files with indirect coverage
changes](https://app.codecov.io/gh/apache/gobblin/pull/3731/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Issue Time Tracking
-------------------
Worklog Id: (was: 874765)
Time Spent: 3h 40m (was: 3.5h)
> Refactor Common Utils between Orchestrator & DagManager
> -------------------------------------------------------
>
> Key: GOBBLIN-1868
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1868
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> Create a Util class to contain functionality re-used between the DagManager
> and Orchestrator when launching executions of a flow spec. In the common
> case, the Orchestrator receives a flow to orchestrate, performs necessary
> validations, and forwards the execution responsibility to the DagManager. The
> DagManager's responsibility is to carry out any flow action requests.
> However, with launch executions now being stored in the DagActionStateStore,
> on restart or leadership change the DagManager has to perform validations
> before executing any launch actions the previous leader was unable to
> complete. Rather than duplicating the code or introducing a circular
> dependency between the DagManager and Orchestrator, this class is utilized to
> store the common functionality. It is stateless and requires all stateful
> pieces to be passed as input from the caller.
> * Note: We expect further refactoring to be done to the DagManager in later
> stage of multi-active development so we do not attempt *major* reorganization
> as abstractions may change.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
