[
https://issues.apache.org/jira/browse/GOBBLIN-1870?focusedWorklogId=875049&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-875049
]
ASF GitHub Bot logged work on GOBBLIN-1870:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Aug/23 01:56
Start Date: 08/Aug/23 01:56
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3733:
URL: https://github.com/apache/gobblin/pull/3733#discussion_r1286518474
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/FlowTriggerHandler.java:
##########
@@ -104,6 +104,8 @@ public FlowTriggerHandler(Config config,
Optional<MultiActiveLeaseArbiter> lease
public void handleTriggerEvent(Properties jobProps, DagActionStore.DagAction
flowAction, long eventTimeMillis)
throws IOException {
if (multiActiveLeaseArbiter.isPresent()) {
+ log.info("Multi-active scheduler about to handle trigger event: [{},
triggerEventTimestamp: {}]", flowAction,
+ eventTimeMillis);
Review Comment:
I'm all for whatever logging is needed to understand and debug. just
wondering here: couldn't essentially similar logging instead live within
`tryAcquireLease`, which is basically what this message announces is about to
be invoked?
e.g. are there too many code paths leading to `tryAcquireLease`, yet no good
way to pinpoint that it was specifically this one?
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/Orchestrator.java:
##########
@@ -244,6 +244,7 @@ public void orchestrate(Spec spec, Properties jobProps,
long triggerTimestampMil
return;
}
Map<String, String> flowMetadata =
TimingEventUtils.getFlowMetadata((FlowSpec) spec);
+ FlowCompilationValidationHelper.addFlowExecutionIdIfAbsent(flowMetadata,
jobExecutionPlanDagOptional.get());
Review Comment:
seems an important property to add.
on that note, do we have any existing `Orchestrator.orchestrate` test case
we might be able to augment with an assert that this is in fact set? (e.g.
using test inputs that would fail that assert w/o the above code change.)
Issue Time Tracking
-------------------
Worklog Id: (was: 875049)
Time Spent: 0.5h (was: 20m)
> Fix missing flow execution id bug causing SQL Error
> ---------------------------------------------------
>
> Key: GOBBLIN-1870
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1870
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Urmi Mustafi
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Seeing the following issue when trying to acquire lease for a flow action:
> {{ava.sql.SQLIntegrityConstraintViolationException: Column
> 'flow_execution_id' cannot be null" }}
> Flow action is created in orchestrate function, during refactoring missed
> executing the line to add flow execution id to metadata to be extracted for
> multi-active case. Adding a log line as well to check the flow action object
> created and verify it has all the flow information.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
