ZihanLi58 commented on code in PR #3737:
URL: https://github.com/apache/gobblin/pull/3737#discussion_r1294079560
##########
gobblin-runtime/src/main/java/org/apache/gobblin/scheduler/JobScheduler.java:
##########
@@ -583,12 +582,17 @@ public void close() throws IOException {
}
/**
- * Get a {@link org.quartz.Trigger} from the given job configuration
properties.
+ * Get a {@link org.quartz.Trigger} from the given job configuration
properties. If triggerSuffix is provided, appends
+ * it to the end of the flow name.
*/
- public static Trigger createTriggerForJob(JobKey jobKey, Properties
jobProps) {
Review Comment:
Did you verify that this method is not called anywhere else? Asking because
this is a backward incompatible change. You can leave this method and make it
by default a call to createTriggerForJob(jobKey, jobProps, Optional.absent())
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
