ZihanLi58 commented on code in PR #3745:
URL: https://github.com/apache/gobblin/pull/3745#discussion_r1298939656
##########
gobblin-modules/gobblin-kafka-common/src/test/java/org/apache/gobblin/source/extractor/extract/kafka/KafkaProduceRateTrackerTest.java:
##########
@@ -58,6 +59,7 @@ public void setUp() {
kafkaPartitions.add(new
KafkaPartition.Builder().withTopicName("test-topic").withId(1).build());
this.workUnitState = new WorkUnitState();
this.workUnitState.setProp(KafkaSource.RECORD_LEVEL_SLA_MINUTES_KEY, 5L);
+ this.workUnitState.setProp(ConfigurationKeys.KAFKA_BROKERS, "testBroker");
Review Comment:
They do not, but the producerate/consumRate tracker call the util method
which assume we do have broker defined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
