[ 
https://issues.apache.org/jira/browse/GOBBLIN-1886?focusedWorklogId=877377&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877377
 ]

ASF GitHub Bot logged work on GOBBLIN-1886:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Aug/23 01:20
            Start Date: 22/Aug/23 01:20
    Worklog Time Spent: 10m 
      Work Description: homatthew opened a new pull request, #3748:
URL: https://github.com/apache/gobblin/pull/3748

   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below!
   
   
   ### JIRA
   - [X] My PR addresses the following [Gobblin 
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references 
them in the PR title. For example, "[GOBBLIN-1886] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1886
   
   
   ### Description
   - [X] Here are some details about my PR, including screenshots (if 
applicable):
   
   Who knows what changed between these versions. 1.0.3 release notes don't 
exist but here are the [1.0.4 ones 
](https://helix.apache.org/1.0.4-docs/releasenotes/release-1.0.4.html)🤣 
   
   The main thing that seems important is ZK client version bumped from 3.4.9 
to 3.6.3, which means the default ZK client version will have a client side 
jute max buffer decreased from 4MB to 1MB. Within LinkedIn, we addressed this 
by overriding with the following java arg. This client buffer will be exceeded 
if a znode exceeds ~8k children. This will occur within Gobblin if your Gobblin 
jobs are particularly large and you are using Zookeeper as your watermark state 
store. NOTE: if you were using zookeeper as your state store at this scale, you 
will see many other scaling issues. Some of which  need to be fixed with just 
more ZK observers, a beefier ZK cluster, or more Helix controllers.  
   
   ```
   -Djute.maxbuffer=4194304
   ```
   
   >Bug Fixes
   > Fixed size history for Scheduled Workflow tasks (#2036)
   > fix bug where generateJobList would iterate until the parallelism is 
reached #2065
   > Fixed website deployment and bump up corresponding dependencies
   > Do not proceed with cluster creation if addCluster() fails. (#2068)
   > Improvements
   > Issue #1970: allow clients to prevent HelixProperty from cloning the 
ZNRecord #2072
   > Fix issue #2117: improve efficiency of ClusterStatusMonitor and 
PerInstanceResourceMonitor, plus misc code cleanup (#2118)
   > support common input for operational input on Maintenance Management API 
#2055
   > MaintenanceManagementService improvement - Allow implementation of 
OperationInterface to return null #2035
   > Allow using passed in connection config when reading cloud config (#2099)
   > Replace non-inclusive terms in tutorial.md (#2039)
   > [issue-1728] upgrade guava due to cve (#2042)
   > upgrade jackson to 2.12.6.1 due to cve (#2043)
   > [issue-1727] upgrade to commons-io 2.11.0 due to cve (#2040)
   > upgrade snakeyaml to v1.30 due to cve (#2041)
   > move to Apache Analytics(Matomo)
   > Bump up helix front from 5 to 13 for angular JS.
   
   [1.1.0](https://helix.apache.org/1.1.0-docs/releasenotes/release-1.1.0.html)
   
   > New ZkClient version bump up
   > The new ZkClient version bumped from 3.4.9 to 3.6.3
   > 
   > ACL support in Helix UI
   > Helix UI (helix-front) support ACLed access.
   > 
   > Detailed Changes
   > Bug Fixes
   > Fixes #2185 NullPointerException in ResourceUtil.java (#2186)
   > Reuse zkclient in BestPossibleExternalViewVerifier and fix resource leak 
(#2180)
   > Fix partition-list row expand bug (#2211)
   > Improvements
   > Cluster deletion confirmation for helix-front (#2274)
   > Implement ViewClusterRefresher caching synchronization (#2199)
   > Optimize HelixTaskExecutor reset() in event of shutdown (#2183)
   > Add TASK_THREADPOOL_RESET_TIMEOUT as system property (#2177)
   > Delete Cluster UI [helix-front] (#2159)
   
   
   ### Tests
   - [X] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   No tests because this is a dependency upgrade. It should be caught at 
compile time and via unit tests
   
   ### Commits
   - [X] My commits all reference JIRA issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 877377)
    Remaining Estimate: 0h
            Time Spent: 10m

> Upgrade to Helix 1.1.0
> ----------------------
>
>                 Key: GOBBLIN-1886
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1886
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Matthew Ho
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to