[
https://issues.apache.org/jira/browse/GOBBLIN-1885?focusedWorklogId=877627&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877627
]
ASF GitHub Bot logged work on GOBBLIN-1885:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Aug/23 20:11
Start Date: 22/Aug/23 20:11
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #3747:
URL: https://github.com/apache/gobblin/pull/3747#discussion_r1302144940
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java:
##########
@@ -82,15 +68,29 @@
import org.apache.gobblin.service.ServiceConfigKeys;
import org.apache.gobblin.service.modules.flowgraph.Dag;
import org.apache.gobblin.service.modules.orchestration.DagManager;
-import org.apache.gobblin.service.modules.orchestration.Orchestrator;
import org.apache.gobblin.service.modules.orchestration.FlowTriggerHandler;
+import org.apache.gobblin.service.modules.orchestration.Orchestrator;
import org.apache.gobblin.service.modules.orchestration.UserQuotaManager;
import org.apache.gobblin.service.modules.spec.JobExecutionPlan;
+import org.apache.gobblin.service.modules.utils.SharedFlowMetricsSingleton;
import org.apache.gobblin.service.monitoring.FlowStatusGenerator;
import org.apache.gobblin.util.ConfigUtils;
import org.apache.gobblin.util.PropertiesUtils;
+import org.apache.helix.HelixManager;
+import org.quartz.CronExpression;
+import org.quartz.DisallowConcurrentExecution;
+import org.quartz.InterruptableJob;
+import org.quartz.JobDataMap;
+import org.quartz.JobDetail;
+import org.quartz.JobExecutionContext;
+import org.quartz.JobExecutionException;
+import org.quartz.SchedulerException;
+import org.quartz.Trigger;
+import org.quartz.UnableToInterruptJobException;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
-import static
org.apache.gobblin.service.ServiceConfigKeys.GOBBLIN_SERVICE_PREFIX;
+import static org.apache.gobblin.service.ServiceConfigKeys.*;
Review Comment:
Can we avoid star imports with
https://gobblin.apache.org/docs/developer-guide/CodingStyle/
Issue Time Tracking
-------------------
Worklog Id: (was: 877627)
Time Spent: 40m (was: 0.5h)
> Unify Timezones of Scheduler Trigger Tracing logs to UTC
> --------------------------------------------------------
>
> Key: GOBBLIN-1885
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1885
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Ensure all logs are in UTC for ease of comparison between other logging done.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
