phet commented on code in PR #3747:
URL: https://github.com/apache/gobblin/pull/3747#discussion_r1302299750
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java:
##########
@@ -467,6 +467,16 @@ protected static String
jobSchedulerTracePrefixBuilder(Properties jobProps) {
jobProps.getProperty(ConfigurationKeys.FLOW_GROUP_KEY, "<<no flow
group>>"));
}
+ /**
+ * Takes a given Date object and converts the timezone to UTC before
returning the number of millseconds since epoch
+ * @param date
+ */
+ public static long asUTCEpochMillis(Date date) {
Review Comment:
if `public` for more than just testability, it may belong in a utility class
rather than here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
