meethngala commented on code in PR #3742:
URL: https://github.com/apache/gobblin/pull/3742#discussion_r1304597141
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java:
##########
@@ -301,15 +305,17 @@ public static boolean isWithinRange(String
cronExpression, int maxNumDaysToSched
if (nextValidTimeAfter == null) {
log.warn("Calculation issue for next valid time for expression: {}.
Will default to true for within range",
cronExpression);
- return true;
+ return false;
Review Comment:
I have added the comments clarifying the need for change in my latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
