[
https://issues.apache.org/jira/browse/GOBBLIN-1880?focusedWorklogId=878218&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-878218
]
ASF GitHub Bot logged work on GOBBLIN-1880:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Aug/23 16:34
Start Date: 24/Aug/23 16:34
Worklog Time Spent: 10m
Work Description: meethngala commented on code in PR #3742:
URL: https://github.com/apache/gobblin/pull/3742#discussion_r1304597141
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java:
##########
@@ -301,15 +305,17 @@ public static boolean isWithinRange(String
cronExpression, int maxNumDaysToSched
if (nextValidTimeAfter == null) {
log.warn("Calculation issue for next valid time for expression: {}.
Will default to true for within range",
cronExpression);
- return true;
+ return false;
Review Comment:
I have added the comments clarifying the need for change in my latest commit.
Issue Time Tracking
-------------------
Worklog Id: (was: 878218)
Time Spent: 1h (was: 50m)
> Handle Invalid Cron Schedules for Gobblin Scheduler
> ---------------------------------------------------
>
> Key: GOBBLIN-1880
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1880
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Meeth Gala
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
