[
https://issues.apache.org/jira/browse/GOBBLIN-1890?focusedWorklogId=878734&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-878734
]
ASF GitHub Bot logged work on GOBBLIN-1890:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Aug/23 00:59
Start Date: 29/Aug/23 00:59
Worklog Time Spent: 10m
Work Description: homatthew opened a new pull request, #3753:
URL: https://github.com/apache/gobblin/pull/3753
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [X] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-1890] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1890
### Description
- [X] Here are some details about my PR, including screenshots (if
applicable):
It's possible for GMIP to support processing GMCEs that correspond to
records from different kafka brokers. This can be done by passing in extra
information as a prefix to the offset range map. However, we must also update
the algorithm for fetching the topic name to allow for a prefix.
For example, the following offset range keys should be valid and all parse
to the `topicname`
- `topicname-0`
- `kafkaBroker1.topicname-0`
- `colocation-kafkabroker1.topicname-0`
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [X] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 878734)
Remaining Estimate: 0h
Time Spent: 10m
> Improve algorithm for fetching topic name from offset range
> -----------------------------------------------------------
>
> Key: GOBBLIN-1890
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1890
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Matthew Ho
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The hive metadata writer should be able to get topic name from offset range
> key formats that have a prefix like the kafka broker
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
