homatthew commented on code in PR #3761:
URL: https://github.com/apache/gobblin/pull/3761#discussion_r1316535119


##########
ligradle/findbugs/findbugsExclude.xml:
##########
@@ -53,4 +53,8 @@
     <Class 
name="org.apache.gobblin.compaction.verify.CompactionTimeRangeVerifier" />
     <Bug pattern="REC_CATCH_EXCEPTION" />
   </Match>
+  <Match>
+    <Class name="org.apache.gobblin.source.extractor.extract.kafka.KafkaTopic" 
/>
+    <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE" />

Review Comment:
   +1. 
   
   Matches the details in the findbug html
   ```
   RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE: Redundant nullcheck of value known 
to be non-null
   
   This method contains a redundant check of a known non-null value against the 
constant null.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to