gautamguptabasant opened a new pull request, #3766: URL: https://github.com/apache/gobblin/pull/3766
Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR" - https://issues.apache.org/jira/browse/GOBBLIN-XXX ### Description - As per the current implementation, early stop is enabled only when multi-partition is also configured. - As part of this change, we are enabling the support for single partition configuration as well. - FYI, early stop is a way to limit the number of records that are fetched/ingested from the CRM source. ### Tests - The current organization of the SalesforceSource class makes it super hard to add tests. Hence not adding tests as part of this tiny change. - Taking up refactoring of the class as an immediate follow up item, where I will be moving the histogram related code to a new service class. Doing so, we would be able to mock those methods and hence easily write tests for the logic in this class. ### Commits - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
