gautamguptabasant opened a new pull request, #3768: URL: https://github.com/apache/gobblin/pull/3768
Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR" - https://issues.apache.org/jira/browse/GOBBLIN-XXX ### Description - In the current form, it's very difficult to add tests for changes as we need to handle all sorts of calls. Moved the code related to histogram calculation to a new class - SalesforceHistogramService. This allows us to mock all that happens in this class, making writing tests easy. - Added a test for the new change introduced as part of https://github.com/apache/gobblin/pull/3766 ### Tests - Added a test for the new change introduced as part of https://github.com/apache/gobblin/pull/3766 ### Commits - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
