[
https://issues.apache.org/jira/browse/GOBBLIN-1905?focusedWorklogId=880095&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-880095
]
ASF GitHub Bot logged work on GOBBLIN-1905:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Sep/23 04:28
Start Date: 13/Sep/23 04:28
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3769:
URL: https://github.com/apache/gobblin/pull/3769#issuecomment-1716927190
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3769?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
> Merging
[#3769](https://app.codecov.io/gh/apache/gobblin/pull/3769?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(df4cbe4) into
[master](https://app.codecov.io/gh/apache/gobblin/commit/16389dc751cebb985c75faf97b35dd6f51c13653?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(16389dc) will **decrease** coverage by `0.48%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3769 +/- ##
============================================
- Coverage 46.39% 45.91% -0.48%
+ Complexity 9553 2175 -7378
============================================
Files 1871 416 -1455
Lines 74831 17981 -56850
Branches 8347 2189 -6158
============================================
- Hits 34716 8256 -26460
+ Misses 36986 8847 -28139
+ Partials 3129 878 -2251
```
[see 1457 files with indirect coverage
changes](https://app.codecov.io/gh/apache/gobblin/pull/3769/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Issue Time Tracking
-------------------
Worklog Id: (was: 880095)
Remaining Estimate: 0h
Time Spent: 10m
> Fix bug where ORC self tune would under estimate native ORC writer memory
> -------------------------------------------------------------------------
>
> Key: GOBBLIN-1905
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1905
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-core
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> During close, the native ORC writer would flush itself - emptying its buffers
> and leading to the memory estimate to be extremely minimal, then record its
> memory estimate in the saved state if it has not recorded an estimate before.
> So for datasets that write a small number of records to file it would greatly
> underestimate the memory within the native ORC writer.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
