[
https://issues.apache.org/jira/browse/GOBBLIN-1906?focusedWorklogId=880266&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-880266
]
ASF GitHub Bot logged work on GOBBLIN-1906:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Sep/23 21:07
Start Date: 13/Sep/23 21:07
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3770:
URL: https://github.com/apache/gobblin/pull/3770#issuecomment-1718319200
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3770?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
> Merging
[#3770](https://app.codecov.io/gh/apache/gobblin/pull/3770?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(f78cd9e) into
[master](https://app.codecov.io/gh/apache/gobblin/commit/16389dc751cebb985c75faf97b35dd6f51c13653?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(16389dc) will **decrease** coverage by `1.92%`.
> Report is 1 commits behind head on master.
> The diff coverage is `25.00%`.
```diff
@@ Coverage Diff @@
## master #3770 +/- ##
============================================
- Coverage 46.39% 44.48% -1.92%
+ Complexity 9553 5084 -4469
============================================
Files 1871 1082 -789
Lines 74831 44050 -30781
Branches 8347 4850 -3497
============================================
- Hits 34716 19594 -15122
+ Misses 36986 22596 -14390
+ Partials 3129 1860 -1269
```
| [Files
Changed](https://app.codecov.io/gh/apache/gobblin/pull/3770?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[...org/apache/gobblin/util/JobConfigurationUtils.java](https://app.codecov.io/gh/apache/gobblin/pull/3770?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSm9iQ29uZmlndXJhdGlvblV0aWxzLmphdmE=)
| `0.00% <0.00%> (ø)` | |
|
[...rg/apache/gobblin/writer/GobblinBaseOrcWriter.java](https://app.codecov.io/gh/apache/gobblin/pull/3770?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tb3JjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3dyaXRlci9Hb2JibGluQmFzZU9yY1dyaXRlci5qYXZh)
| `73.23% <100.00%> (-0.38%)` | :arrow_down: |
... and [1357 files with indirect coverage
changes](https://app.codecov.io/gh/apache/gobblin/pull/3770/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Issue Time Tracking
-------------------
Worklog Id: (was: 880266)
Time Spent: 20m (was: 10m)
> protect against nulls when converting `State` to a `hadoop.conf.Configuration`
> ------------------------------------------------------------------------------
>
> Key: GOBBLIN-1906
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1906
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-core
> Reporter: Kip Kohn
> Assignee: Abhishek Tiwari
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> A customer reported seeing:
> {code:java}
> Error: java.io.IOException: Task failed: java.lang.IllegalArgumentException:
> The value of property <<redacted>> must not be null
> at
> com.google.common.base.Preconditions.checkArgument(Preconditions.java:146)
> at org.apache.hadoop.conf.Configuration.set(Configuration.java:1260)
> at org.apache.hadoop.conf.Configuration.set(Configuration.java:1241)
> at
> org.apache.gobblin.util.JobConfigurationUtils.putStateIntoConfiguration(JobConfigurationUtils.java:95)
> at org.apache.gobblin.writer.FsDataWriter.<init>(FsDataWriter.java:102)
> at org.apache.gobblin.writer.GobblinBaseOrcWriter.<init
> (GobblinBaseOrcWriter.java:65)
> at
> org.apache.gobblin.writer.GobblinOrcWriter.<init>(GobblinOrcWriter.java:42)
> at <<redacted>>
> at
> org.apache.gobblin.writer.PartitionedDataWriter$4.get(PartitionedDataWriter.java:230)
> at
> org.apache.gobblin.writer.PartitionedDataWriter$4.get(PartitionedDataWriter.java:225)
> at
> org.apache.gobblin.writer.CloseOnFlushWriterWrapper.<init>(CloseOnFlushWriterWrapper.java:73)
> at
> org.apache.gobblin.writer.PartitionedDataWriter.<init>(PartitionedDataWriter.java:224)
> at org.apache.gobblin.runtime.fork.Fork.buildWriter(Fork.java:571)
> at
> org.apache.gobblin.runtime.fork.Fork.buildWriterIfNotPresent(Fork.java:579)
> at org.apache.gobblin.runtime.fork.Fork.processRecord(Fork.java:525)
> at
> org.apache.gobblin.runtime.fork.AsynchronousFork.processRecord(AsynchronousFork.java:103)
> at
> org.apache.gobblin.runtime.fork.AsynchronousFork.processRecords(AsynchronousFork.java:86)
> at org.apache.gobblin.runtime.fork.Fork.run(Fork.java:257)
> at
> org.apache.gobblin.util.executors.MDCPropagatingRunnable.run(MDCPropagatingRunnable.java:39)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at
> com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:111)
> at
> com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:58)
> at
> com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:75)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748) (Gobblin task id <<redacted>>,
> container id attempt_1690893552521_3376012_m_000111_0)
> at
> org.apache.gobblin.runtime.GobblinMultiTaskAttempt.persistTaskStateStore(GobblinMultiTaskAttempt.java:367)
> ... {code}
> the appears to arise from concurrent modification to the `State`'s underlying
> `Properties` (i.e. between the time the `keySet()` is first read and when
> each value is accessed from the same `Properties`).
> although the customer's impl seems to warrant synchronization, given that a
> null-value is certain to be rejected by `o.a.hadoop.conf.Configuration`,
> defensively filter those out ahead of time.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
