phet commented on code in PR #3772:
URL: https://github.com/apache/gobblin/pull/3772#discussion_r1326148140
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java:
##########
@@ -466,8 +466,9 @@ public synchronized void scheduleJob(Properties jobProps,
JobListener jobListene
@Override
protected void logNewlyScheduledJob(JobDetail job, Trigger trigger) {
Properties jobProps = (Properties) job.getJobDataMap().get(PROPERTIES_KEY);
- log.info(jobSchedulerTracePrefixBuilder(jobProps) + "nextTriggerTime: {} -
Job newly scheduled",
- asUTCEpochMillis(trigger.getNextFireTime()));
+ log.info(jobSchedulerTracePrefixBuilder(jobProps) + "nextTriggerTime: {}
localConversionTriggerTime:{} - Job newly "
Review Comment:
shouldn't this be named localConversion*Next*TriggerTime ?
nit: rather than the prefix "local conversion", which suggests how we
calculate it, I'd opt instead for "localTZ" or "localZoned", which names what
it is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
