[ 
https://issues.apache.org/jira/browse/GOBBLIN-1916?focusedWorklogId=881200&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-881200
 ]

ASF GitHub Bot logged work on GOBBLIN-1916:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Sep/23 16:40
            Start Date: 21/Sep/23 16:40
    Worklog Time Spent: 10m 
      Work Description: umustafi opened a new pull request, #3783:
URL: https://github.com/apache/gobblin/pull/3783

   
   
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below!
   
   
   ### JIRA
   - [X] My PR addresses the following [Gobblin 
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references 
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1916
   
   ### Description
   - [X] Here are some details about my PR, including screenshots (if 
applicable):
   Including `flow execution id` as a part of multi-active lease arbitration 
for `LAUNCH` events is frequently causing the same trigger on multiple hosts to 
be perceived as unique flow executions since the `flow execution id` reflects 
the system clock of the participant. For a single flow trigger, there may be up 
to N flow execution ids where N is the number of active participants. The same 
flow action is perceived as unique from the other ones and excess flows are 
launched concurrently (upon which the additional ones are cancelled). Remove 
all use of the flow execution id for the `LAUNCH` case right now. In the 
future, we will generalize the arbiter for other flow actions when we determine 
the value they will require for arbitration. 
   
   ### Tests
   - [X] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   Ran the `MysqlMultiActiveLeaseArbiterTest` unit tests
   
   ### Commits
   - [X] My commits all reference JIRA issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 881200)
    Remaining Estimate: 0h
            Time Spent: 10m

> Remove flowExecutionId from Multi-Active Lease Arbitration
> ----------------------------------------------------------
>
>                 Key: GOBBLIN-1916
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1916
>             Project: Apache Gobblin
>          Issue Type: New Feature
>          Components: gobblin-service
>            Reporter: Urmi Mustafi
>            Assignee: Abhishek Tiwari
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Including flow execution id as a part of multi-active lease arbitration for 
> LAUNCH events is frequently causing the same trigger on multiple hosts to be 
> perceived as unique flow executions since the flow execution id reflects the 
> system clock of the participant. For a single flow trigger, there may be up 
> to N number of flow execution ids where N is the number of active 
> participants. The same flow action is perceived as unique from the other ones 
> and excess flows are launched concurrently (upon which the additional ones 
> are cancelled). Remove all use of the flow execution id for the LAUNCH case 
> right now. In the future, we will generalize the arbiter for other flow 
> actions when we determine the value they will require for arbitration. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to